Repository navigation
Firefox: Removing SDK extension tests and generalizing selenium tests… - #11789
Conversation
|
|
||
| To add tests, put them in `./https-everywhere-tests/tests`. | ||
|
|
||
| # Manual tests |
There was a problem hiding this comment.
You're deleting the manual tests section, but I think they haven't actually been implemented as Selenium tests yet, right? We should probably keep them around.
| // Show all logs. | ||
| user_pref("extensions.https_everywhere.LogLevel", 0); | ||
| user_pref("extensions.https_everywhere.log_to_stdout", true); | ||
| // Make it quicker to make manual config changes. |
There was a problem hiding this comment.
Why is this file only partially deleted?
There was a problem hiding this comment.
Ah, these are the prefs that are only relevant for the XPCOM extension. The other prefs are necessary for debugging, installing the extension without a valid signature, etc.
There was a problem hiding this comment.
These changes belong in #11791, I'll move them over.
| @@ -0,0 +1,98 @@ | |||
| #!/usr/bin/env python2.7 | |||
| # | |||
| # Run Chromium tests for HTTPS Everywhere | |||
| driver = webdriver.Firefox(fp, firefox_binary=binary, log_path=os.devnull) | ||
| else: | ||
| driver = webdriver.Firefox(fp, log_path=os.devnull) | ||
| # Allow the extension time to load |
There was a problem hiding this comment.
This comment should be right above the time.sleep. But it's a little alarming: HTTPS Everywhere should ideally redirect all relevant requests. If requests that happen early in the browser load skip the redirects, that's a bug. It looks like Chrome doesn't have an equivalent sleep. Do you know why this is necessary in Firefox?
| if driver.current_url.startswith('https'): | ||
| print bcolors.OKGREEN + sys.argv[1] + ": HTTP to HTTPS redirection successful" + bcolors.ENDC | ||
| elif driver.current_url.startswith('http'): | ||
| print bcolors.FAIL + sys.argv[1] + "Chromium: HTTP to HTTPS redirection failed" + bcolors.ENDC |
fb6ead2 to
febdf14
Compare
febdf14 to
28f49a1
Compare
… to support FF